Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mekhanik evgenii/fix 525 3 #557

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Mekhanik evgenii/fix 525 3 #557

merged 6 commits into from
Jan 29, 2024

Conversation

EvgeniiMekhanik
Copy link
Contributor

No description provided.

RomanBelozerov
RomanBelozerov requested changes Dec 29, 2023
View reviewed changes
framework/custom_error_page.py Outdated Show resolved Hide resolved
http_general/test_block_action.py Outdated Show resolved Hide resolved
http_general/test_block_action.py Outdated Show resolved Hide resolved
http2_general/test_h2_block_action.py Outdated Show resolved Hide resolved
http2_general/test_h2_block_action.py Outdated Show resolved Hide resolved
http2_general/test_h2_block_action.py Outdated Show resolved Hide resolved
http2_general/test_h2_block_action.py Outdated Show resolved Hide resolved
http2_general/test_h2_block_action.py Outdated Show resolved Hide resolved
http2_general/test_h2_block_action.py Outdated Show resolved Hide resolved
http2_general/test_h2_block_action.py Outdated Show resolved Hide resolved
@EvgeniiMekhanik EvgeniiMekhanik force-pushed the MekhanikEvgenii/fix-525-3 branch 3 times, most recently from ad6370f to 920c9e4 Compare December 29, 2023 14:04
Vitaly-Skopets
Vitaly-Skopets reviewed Jan 3, 2024
View reviewed changes
helpers/custom_error_page.py Show resolved Hide resolved
http_general/test_block_action.py Show resolved Hide resolved
http_general/test_block_action.py Show resolved Hide resolved
http_general/test_block_action.py Show resolved Hide resolved
http_general/test_block_action.py Show resolved Hide resolved
http_general/test_block_action.py Show resolved Hide resolved
@EvgeniiMekhanik
Implement tests for custom error pages
e415f19 
After implementing graceful shutdown on
error, we can check how we send long custom
error pages.
@EvgeniiMekhanik
Enabled some tests blocked by #525
637ae2e
@EvgeniiMekhanik
Enable tests blocked by 1975
bde77ba
@EvgeniiMekhanik
Implement tests to check handling frames after closing
6c98a9d 
We need to check how we handle different type of frames
after closing connection.
@EvgeniiMekhanik
Close connection and socket in TLS tests.
0fba90d 
We should close socket in all TLS tests,
to prevent connection hang.
@EvgeniiMekhanik
Fixes according review
a095eb0
@EvgeniiMekhanik EvgeniiMekhanik merged commit 4a1f43d into master Jan 29, 2024
@EvgeniiMekhanik EvgeniiMekhanik deleted the MekhanikEvgenii/fix-525-3 branch January 29, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vitaly-Skopets Vitaly-Skopets Vitaly-Skopets left review comments

@RomanBelozerov RomanBelozerov RomanBelozerov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EvgeniiMekhanik @RomanBelozerov @Vitaly-Skopets